Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip async checksum test on ceph due to files_primary_s3-issue-128 #33320

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Skip async checksum test on ceph due to files_primary_s3-issue-128 #33320

merged 1 commit into from
Oct 29, 2018

Conversation

phil-davis
Copy link
Contributor

Description

Skip test that is known to fail on files_primary_s3

Motivation and Context

A new test scenario for async upload with checksum error was added.
It does not pass on files_primary_s3 due to owncloud/files_primary_s3#128

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis self-assigned this Oct 29, 2018
@phil-davis
Copy link
Contributor Author

Backport is not needed, because the test is already skipped in stable10
The skip was missed when forward-porting that "async move" PR from stable10 to master

@codecov
Copy link

codecov bot commented Oct 29, 2018 •
edited
Loading

Codecov Report

Merging #33320 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #33320   +/-   ##
=========================================
  Coverage     64.06%   64.06%           
  Complexity    18276    18276           
=========================================
  Files          1190     1190           
  Lines         69047    69047           
  Branches       1271     1271           
=========================================
  Hits          44234    44234           
  Misses        24443    24443           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.88% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <ø> (ø) 18276 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a91fe3...ca43867. Read the comment docs.

@phil-davis phil-davis merged commit a4c30c3 into master Oct 29, 2018
@phil-davis phil-davis deleted the skip-files_primary_s3-issue-128 branch October 29, 2018 04:51
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paurakhsharma paurakhsharma paurakhsharma approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@phil-davis phil-davis

Labels
3 - To Review dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @paurakhsharma